Skip to content

fix(runtime-core): change log to error for remote removal failure and remove redundant log function#4514

Merged
2heal1 merged 2 commits intomainfrom
fix/logger
Mar 14, 2026
Merged

fix(runtime-core): change log to error for remote removal failure and remove redundant log function#4514
2heal1 merged 2 commits intomainfrom
fix/logger

Conversation

@2heal1
Copy link
Copy Markdown
Member

@2heal1 2heal1 commented Mar 10, 2026

Description

fix(runtime-core): change log to error for remote removal failure and remove redundant log function

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 10, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 44dd5f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 45 packages
Name Type
@module-federation/runtime-core Patch
@module-federation/runtime Patch
@module-federation/bridge-react Patch
@module-federation/devtools Patch
@module-federation/data-prefetch Patch
@module-federation/dts-plugin Patch
@module-federation/metro Patch
@module-federation/modern-js-v3 Patch
@module-federation/modern-js Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/retry-plugin Patch
@module-federation/runtime-tools Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/bridge-vue3 Patch
@module-federation/enhanced Patch
@module-federation/metro-plugin-rnc-cli Patch
@module-federation/metro-plugin-rnef Patch
shared-tree-shaking-with-server-host Patch
shared-tree-shaking-with-server-provider Patch
@module-federation/rsbuild-plugin Patch
node-dynamic-remote-new-version Patch
node-dynamic-remote Patch
@module-federation/rspack Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/rspress-plugin Patch
@module-federation/storybook-addon Patch
shared-tree-shaking-no-server-host Patch
shared-tree-shaking-no-server-provider Patch
remote5 Patch
remote6 Patch
website-new Patch
@module-federation/sdk Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/error-codes Patch
create-module-federation Patch
@module-federation/cli Patch
@module-federation/treeshake-server Patch
@module-federation/treeshake-frontend Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 10, 2026 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 44dd5f7
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/69b3f8aa41b4ca0007486e42
😎 Deploy Preview https://deploy-preview-4514--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 10, 2026 •
edited
Loading

Open in StackBlitz

@module-federation/devtools

pnpm add https://pkg.pr.new/@module-federation/devtools@7dc101e

@module-federation/cli

pnpm add https://pkg.pr.new/@module-federation/cli@7dc101e

create-module-federation

pnpm add https://pkg.pr.new/create-module-federation@7dc101e

@module-federation/data-prefetch

pnpm add https://pkg.pr.new/@module-federation/data-prefetch@7dc101e

@module-federation/dts-plugin

pnpm add https://pkg.pr.new/@module-federation/dts-plugin@7dc101e

@module-federation/enhanced

pnpm add https://pkg.pr.new/@module-federation/enhanced@7dc101e

@module-federation/error-codes

pnpm add https://pkg.pr.new/@module-federation/error-codes@7dc101e

@module-federation/esbuild

pnpm add https://pkg.pr.new/@module-federation/esbuild@7dc101e

@module-federation/managers

pnpm add https://pkg.pr.new/@module-federation/managers@7dc101e

@module-federation/manifest

pnpm add https://pkg.pr.new/@module-federation/manifest@7dc101e

@module-federation/metro

pnpm add https://pkg.pr.new/@module-federation/metro@7dc101e

@module-federation/metro-plugin-rnc-cli

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rnc-cli@7dc101e

@module-federation/metro-plugin-rnef

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rnef@7dc101e

@module-federation/modern-js

pnpm add https://pkg.pr.new/@module-federation/modern-js@7dc101e

@module-federation/modern-js-v3

pnpm add https://pkg.pr.new/@module-federation/modern-js-v3@7dc101e

@module-federation/native-federation-tests

pnpm add https://pkg.pr.new/@module-federation/native-federation-tests@7dc101e

@module-federation/native-federation-typescript

pnpm add https://pkg.pr.new/@module-federation/native-federation-typescript@7dc101e

@module-federation/nextjs-mf

pnpm add https://pkg.pr.new/@module-federation/nextjs-mf@7dc101e

@module-federation/node

pnpm add https://pkg.pr.new/@module-federation/node@7dc101e

@module-federation/retry-plugin

pnpm add https://pkg.pr.new/@module-federation/retry-plugin@7dc101e

@module-federation/rsbuild-plugin

pnpm add https://pkg.pr.new/@module-federation/rsbuild-plugin@7dc101e

@module-federation/rspack

pnpm add https://pkg.pr.new/@module-federation/rspack@7dc101e

@module-federation/rspress-plugin

pnpm add https://pkg.pr.new/@module-federation/rspress-plugin@7dc101e

@module-federation/runtime

pnpm add https://pkg.pr.new/@module-federation/runtime@7dc101e

@module-federation/runtime-core

pnpm add https://pkg.pr.new/@module-federation/runtime-core@7dc101e

@module-federation/runtime-tools

pnpm add https://pkg.pr.new/@module-federation/runtime-tools@7dc101e

@module-federation/sdk

pnpm add https://pkg.pr.new/@module-federation/sdk@7dc101e

@module-federation/storybook-addon

pnpm add https://pkg.pr.new/@module-federation/storybook-addon@7dc101e

@module-federation/third-party-dts-extractor

pnpm add https://pkg.pr.new/@module-federation/third-party-dts-extractor@7dc101e

@module-federation/treeshake-frontend

pnpm add https://pkg.pr.new/@module-federation/treeshake-frontend@7dc101e

@module-federation/treeshake-server

pnpm add https://pkg.pr.new/@module-federation/treeshake-server@7dc101e

@module-federation/typescript

pnpm add https://pkg.pr.new/@module-federation/typescript@7dc101e

@module-federation/utilities

pnpm add https://pkg.pr.new/@module-federation/utilities@7dc101e

@module-federation/webpack-bundler-runtime

pnpm add https://pkg.pr.new/@module-federation/webpack-bundler-runtime@7dc101e

@module-federation/bridge-react

pnpm add https://pkg.pr.new/@module-federation/bridge-react@7dc101e

@module-federation/bridge-react-webpack-plugin

pnpm add https://pkg.pr.new/@module-federation/bridge-react-webpack-plugin@7dc101e

@module-federation/bridge-shared

pnpm add https://pkg.pr.new/@module-federation/bridge-shared@7dc101e

@module-federation/bridge-vue3

pnpm add https://pkg.pr.new/@module-federation/bridge-vue3@7dc101e

@module-federation/inject-external-runtime-core-plugin

pnpm add https://pkg.pr.new/@module-federation/inject-external-runtime-core-plugin@7dc101e

commit: 7dc101e

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 10, 2026 •
edited
Loading

Bundle Size Report

11 package(s) changed, 29 unchanged.

Package dist + ESM entry

Package Total dist (raw) Delta ESM gzip Delta
@module-federation/cli 26.7 kB no change 786 B no change
@module-federation/core 39.1 kB no change 173 B no change
@module-federation/devtools 473.2 kB no change 3.9 kB no change
@module-federation/enhanced 809.4 kB no change 672 B no change
@module-federation/managers 69.9 kB no change 334 B no change
@module-federation/manifest 138.4 kB no change 182 B no change
@module-federation/metro-plugin-rnc-cli 0 B no change 314 B no change
@module-federation/node 189.2 kB no change 217 B no change
@module-federation/runtime-tools 7.8 kB +65 B (+0.8%) 142 B no change
@module-federation/storybook-addon 76.5 kB no change 100 B no change
@module-federation/utilities 110.6 kB no change 328 B no change

Bundle targets

Package Web bundle (gzip) Delta Node bundle (gzip) Delta
@module-federation/cli 2.3 kB -33 B (-1.4%) 2.3 kB -33 B (-1.4%)
@module-federation/core 1.1 kB -31 B (-2.8%) 1.0 kB -31 B (-2.9%)
@module-federation/devtools 20.8 kB -26 B (-0.1%) 20.8 kB -26 B (-0.1%)
@module-federation/enhanced 3.0 kB -43 B (-1.4%) 3.0 kB -43 B (-1.4%)
@module-federation/managers 2.4 kB -27 B (-1.1%) 2.4 kB -27 B (-1.1%)
@module-federation/manifest 6.2 kB -37 B (-0.6%) 6.2 kB -37 B (-0.6%)
@module-federation/metro-plugin-rnc-cli 411 B -25 B (-5.7%) 411 B -25 B (-5.7%)
@module-federation/node 9.2 kB -27 B (-0.3%) 9.2 kB -27 B (-0.3%)
@module-federation/runtime-tools 89 B no change 89 B no change
@module-federation/storybook-addon 1.9 kB -25 B (-1.3%) 1.7 kB -25 B (-1.4%)
@module-federation/utilities 2.6 kB -31 B (-1.2%) 2.6 kB -31 B (-1.2%)

Consumer scenarios

Scenario Web output (gzip) Delta Node output (gzip) Delta Gap (node-web) Delta
Enhanced remoteEntry 19.5 kB -17 B (-0.1%) 20.5 kB -22 B (-0.1%) +1.0 kB -5 B

Total dist (raw): 6.30 MB (+65 B (+0.0%))
Total ESM gzip: 73.4 kB (no change)
Total web bundle (gzip): 178.0 kB (-305 B (-0.2%))
Total node bundle (gzip): 178.5 kB (-305 B (-0.2%))
Tracked ./bundler entry gzip: 556 B (no change)
Tracked ./bundler web bundle (gzip): 4.5 kB (no change)
Tracked ./bundler node bundle (gzip): 4.5 kB (no change)

Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as ./bundler are measured separately so ENV_TARGET-driven tree-shaking is visible. Bare imports are externalized to keep package-level sizes consistent, and assets are emitted as resources.

ScriptedAlchemy
ScriptedAlchemy reviewed Mar 10, 2026
View reviewed changes
packages/runtime-core/src/remote/index.ts Outdated
}
} catch (err) {
logger.log('removeRemote fail: ', err);
logger.error('removeRemote fail: ', err);
Copy link
Copy Markdown
Member

@ScriptedAlchemy ScriptedAlchemy Mar 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeRemote failed, not 'fail'

@2heal1 2heal1 merged commit 5c746e3 into main Mar 14, 2026
26 checks passed
@2heal1 2heal1 deleted the fix/logger branch March 14, 2026 01:09
@2heal1 2heal1 mentioned this pull request Mar 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScriptedAlchemy ScriptedAlchemy ScriptedAlchemy approved these changes

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@2heal1 @ScriptedAlchemy