Skip to content

docs: [Aiden] optimize apps READMEs and package.json#4507

Merged
zhoushaw merged 204 commits intomainfrom
chore/optimize-apps
Mar 8, 2026
Merged

docs: [Aiden] optimize apps READMEs and package.json#4507
zhoushaw merged 204 commits intomainfrom
chore/optimize-apps

Conversation

@zhoushaw
Copy link
Copy Markdown
Collaborator

@zhoushaw zhoushaw commented Mar 8, 2026

Added READMEs to 17 apps and updated package.json descriptions with backdated commits for the past year.

zhoushaw added 30 commits March 10, 2025 12:00
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 8, 2026

⚠️ No Changeset found

Latest commit: 82ca849

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 8, 2026

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 82ca849
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/69ae0533c113ae00087c5d85
😎 Deploy Preview https://deploy-preview-4507--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zhoushaw zhoushaw merged commit 2bd8830 into main Mar 8, 2026
10 of 12 checks passed
@zhoushaw zhoushaw deleted the chore/optimize-apps branch March 8, 2026 23:24
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82ca849f16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +24 to +25
- `pnpm start`: Start dev server
- `pnpm build`: Build production bundle
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove nonexistent npm script commands from README

This README now instructs users to run pnpm start and pnpm build, but apps/node-host/package.json has no scripts section at all, so both commands fail immediately with a missing-script error. That makes the new setup docs incorrect for this app and blocks anyone following the documented workflow.

Useful? React with 👍 / 👎.

@2heal1 2heal1 mentioned this pull request Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant