Merged
Conversation
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 94fa93c The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc8c52e1e6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| if (!remoteEntry) { | ||
| const remotes = (ctx.mfConfig && ctx.mfConfig.remotes) || {}; | ||
| const remoteValue = remotes[moduleName]; |
There was a problem hiding this comment.
Support MFContext remote arrays in module lookup
This lookup treats mfConfig.remotes as a name-keyed object, but the new MFContext contract in this commit models remotes as an array of entries (MFConfigInfo.remotes) and runtime context generation also emits arrays. When the script receives that valid context shape, remoteValue is always undefined and mf-module-info reports Remote "<name>" not found, so consumer-mode resolution fails even though the remote is present.
Useful? React with 👍 / 👎.
|
|
||
| function checkMultiVersion(ctx, results) { | ||
| const artifacts = ctx.buildArtifacts || {}; | ||
| const manifest = artifacts.mfManifest; |
There was a problem hiding this comment.
Read manifest from the documented buildArtifacts key
The multi-version detector reads ctx.buildArtifacts.mfManifest, but the context schema added in this change uses buildArtifacts.manifest (and the mf-context skill describes populating that manifest field from dist/mf-manifest.json). With correctly shaped context input, this value is undefined, so the check returns early and never reports duplicated shared-package versions.
Useful? React with 👍 / 👎.
…or error handling
Member
|
Yo this is awesome |
# Conflicts: # apps/website-new/module-federation.config.ts # packages/error-codes/package.json # packages/error-codes/project.json # packages/error-codes/src/desc.ts
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/data-prefetch
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Contributor
Bundle Size Report8 package(s) changed, 33 unchanged.
Total dist: 6.37 MB (+19.6 kB (+0.3%)) |
ScriptedAlchemy
approved these changes
Mar 6, 2026
ScriptedAlchemy
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a set of Agent Skills for Module Federation 2.0 — loadable instruction sets for AI coding assistants (Claude Code, Cursor, Windsurf, etc.) that give them built-in knowledge of MF internals, enabling configuration diagnosis, type fixes, and dependency troubleshooting directly inside the editor.
9 skills added:
mf-docs/mf-docsmf-context/mf-contextmf-module-info/mf-module-infomf-integrate/mf-integratemf-type-check/mf-type-checkmf-shared-deps/mf-shared-depsmf-perf/mf-perfmf-config-check/mf-config-checkmf-bridge-check/mf-bridge-checkInstallation:
Docs: Added zh/en AI Skills documentation pages under
docs/guide/ai-skills/