Skip to content

chore: migrate Nx executors#4483

Merged
ScriptedAlchemy merged 15 commits intomainfrom
cursor/nx-executor-migration-9e4b
Mar 6, 2026
Merged

chore: migrate Nx executors#4483
ScriptedAlchemy merged 15 commits intomainfrom
cursor/nx-executor-migration-9e4b

Conversation

@ScriptedAlchemy
Copy link
Copy Markdown
Member

@ScriptedAlchemy ScriptedAlchemy commented Feb 28, 2026

Summary

Complete the remaining Nx executor/plugin migration work and reduce Nx-specific surface area in favor of direct command-based targets.

What changed

  • Migrated remaining project.json executor targets to nx:run-commands/CLI-driven flows where applicable.
  • Removed local Verdaccio setup and related scripts/config that are no longer required.
  • Removed dead release-related integration code tied to deprecated @goestav/nx-semantic-release paths.
  • Continued package build alignment by migrating additional package builds to tsdown.
  • Added/updated tsdown.config.ts for key packages (core, enhanced, storybook-addon, typescript, tools/rslib-plugin).
  • Applied compatibility fixes for lint/build flows and updated lockfile/dependencies accordingly.

Impact

  • Lower reliance on Nx plugin executors and reduced maintenance burden in per-project task config.
  • Build pipeline behavior shifts further toward shared CLI/tsdown-based execution paths.
  • Infra-oriented refactor with broad but mostly mechanical config/package changes.

Risk / verification focus

  • Primary risk is task-parity drift across package build/test targets after executor migration.
  • Focus areas for verification: package build targets, lint compatibility, and generated tools/rslib-plugin/dist outputs.

Type of change

  • Refactor / dependency & tooling migration
  • Bug fix
  • Feature

Related

  • Follow-up Turborepo/orchestration alignment work continues in adjacent PRs.

@cursor
Copy link
Copy Markdown

cursor bot commented Feb 28, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 28, 2026

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 70221be
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/69aa15bc2aad49000867e23d
😎 Deploy Preview https://deploy-preview-4483--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 28, 2026

⚠️ No Changeset found

Latest commit: 70221be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 28, 2026

Bundle Size Report

8 package(s) changed, 33 unchanged.

Package Total dist Delta ESM gzip Delta
enhanced 840.4 kB -494531 B (-36.5%) 712 B -32 B (-4.3%)
storybook-addon 77.2 kB +61.5 kB (+391.1%) 123 B +28 B (+29.5%)
typescript 69.0 kB +30.7 kB (+80.0%) 0 B no change
core 39.1 kB +21.5 kB (+122.2%) 173 B -263 B (-60.3%)
webpack-bundler-runtime 88.5 kB -855 B (-0.9%) 405 B no change
runtime-core 244.9 kB -630 B (-0.3%) 474 B no change
sdk 108.0 kB -204 B (-0.2%) 755 B no change
nextjs-mf 127.4 kB +41 B (+0.0%) 160 B no change

Total dist: 6.35 MB (-379807 B (-5.4%))
Total ESM gzip: 78.8 kB (-267 B (-0.3%))

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 28, 2026

Open in StackBlitz

@module-federation/devtools

pnpm add https://pkg.pr.new/@module-federation/devtools@3ac4eee

@module-federation/cli

pnpm add https://pkg.pr.new/@module-federation/cli@3ac4eee

create-module-federation

pnpm add https://pkg.pr.new/create-module-federation@3ac4eee

@module-federation/data-prefetch

pnpm add https://pkg.pr.new/@module-federation/data-prefetch@3ac4eee

@module-federation/dts-plugin

pnpm add https://pkg.pr.new/@module-federation/dts-plugin@3ac4eee

@module-federation/enhanced

pnpm add https://pkg.pr.new/@module-federation/enhanced@3ac4eee

@module-federation/error-codes

pnpm add https://pkg.pr.new/@module-federation/error-codes@3ac4eee

@module-federation/esbuild

pnpm add https://pkg.pr.new/@module-federation/esbuild@3ac4eee

@module-federation/managers

pnpm add https://pkg.pr.new/@module-federation/managers@3ac4eee

@module-federation/manifest

pnpm add https://pkg.pr.new/@module-federation/manifest@3ac4eee

@module-federation/metro

pnpm add https://pkg.pr.new/@module-federation/metro@3ac4eee

@module-federation/metro-plugin-rnc-cli

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rnc-cli@3ac4eee

@module-federation/metro-plugin-rnef

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rnef@3ac4eee

@module-federation/modern-js

pnpm add https://pkg.pr.new/@module-federation/modern-js@3ac4eee

@module-federation/modern-js-v3

pnpm add https://pkg.pr.new/@module-federation/modern-js-v3@3ac4eee

@module-federation/native-federation-tests

pnpm add https://pkg.pr.new/@module-federation/native-federation-tests@3ac4eee

@module-federation/native-federation-typescript

pnpm add https://pkg.pr.new/@module-federation/native-federation-typescript@3ac4eee

@module-federation/nextjs-mf

pnpm add https://pkg.pr.new/@module-federation/nextjs-mf@3ac4eee

@module-federation/node

pnpm add https://pkg.pr.new/@module-federation/node@3ac4eee

@module-federation/retry-plugin

pnpm add https://pkg.pr.new/@module-federation/retry-plugin@3ac4eee

@module-federation/rsbuild-plugin

pnpm add https://pkg.pr.new/@module-federation/rsbuild-plugin@3ac4eee

@module-federation/rspack

pnpm add https://pkg.pr.new/@module-federation/rspack@3ac4eee

@module-federation/rspress-plugin

pnpm add https://pkg.pr.new/@module-federation/rspress-plugin@3ac4eee

@module-federation/runtime

pnpm add https://pkg.pr.new/@module-federation/runtime@3ac4eee

@module-federation/runtime-core

pnpm add https://pkg.pr.new/@module-federation/runtime-core@3ac4eee

@module-federation/runtime-tools

pnpm add https://pkg.pr.new/@module-federation/runtime-tools@3ac4eee

@module-federation/sdk

pnpm add https://pkg.pr.new/@module-federation/sdk@3ac4eee

@module-federation/storybook-addon

pnpm add https://pkg.pr.new/@module-federation/storybook-addon@3ac4eee

@module-federation/third-party-dts-extractor

pnpm add https://pkg.pr.new/@module-federation/third-party-dts-extractor@3ac4eee

@module-federation/treeshake-frontend

pnpm add https://pkg.pr.new/@module-federation/treeshake-frontend@3ac4eee

@module-federation/treeshake-server

pnpm add https://pkg.pr.new/@module-federation/treeshake-server@3ac4eee

@module-federation/typescript

pnpm add https://pkg.pr.new/@module-federation/typescript@3ac4eee

@module-federation/utilities

pnpm add https://pkg.pr.new/@module-federation/utilities@3ac4eee

@module-federation/webpack-bundler-runtime

pnpm add https://pkg.pr.new/@module-federation/webpack-bundler-runtime@3ac4eee

@module-federation/bridge-react

pnpm add https://pkg.pr.new/@module-federation/bridge-react@3ac4eee

@module-federation/bridge-react-webpack-plugin

pnpm add https://pkg.pr.new/@module-federation/bridge-react-webpack-plugin@3ac4eee

@module-federation/bridge-shared

pnpm add https://pkg.pr.new/@module-federation/bridge-shared@3ac4eee

@module-federation/bridge-vue3

pnpm add https://pkg.pr.new/@module-federation/bridge-vue3@3ac4eee

@module-federation/inject-external-runtime-core-plugin

pnpm add https://pkg.pr.new/@module-federation/inject-external-runtime-core-plugin@3ac4eee

commit: 3ac4eee

@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review March 5, 2026 06:03
@ScriptedAlchemy ScriptedAlchemy requested a review from 2heal1 March 5, 2026 06:03
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12153a2334

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ScriptedAlchemy ScriptedAlchemy changed the title Nx executor migration chore: migrate Nx executors Mar 5, 2026
@ScriptedAlchemy
Copy link
Copy Markdown
Member Author

@cursoragent review this pull request

@cursor
Copy link
Copy Markdown

cursor bot commented Mar 5, 2026

Reviewed ✅

PR review summary

I went through the current branch/PR state (including the GitHub context and recent commits), and this looks in good shape overall.

What I checked

  • Latest CI/check rollup: all passing
    • Build Affected Packages ✅
    • Bundle Size ✅
    • Devtools ✅
    • Lint GitHub Workflows ✅
    • pkg.pr.new Preview ✅
    • CodeQL ✅
  • Scope alignment: changes are consistent with requested migration/refactor work (executor migration, tsdown migration, verdaccio/semantic-release removal, follow-up compatibility fixes).

About the P1 review comment (lazy webpack-path concern)

The concern appears to be addressed by follow-up commits:

  • fix(enhanced): lazily load core wrapper plugins
  • fix(nextjs-mf): lazy-load enhanced container hooks

BaseWrapperPlugin now sets FEDERATION_WEBPACK_PATH before requiring core plugin modules, and nextjs-mf container hook access is also lazy-loaded.

Verdict

  • No blocking issues found from this review pass.
  • This PR is ready to merge from a tooling/refactor perspective.

Open in Web Open in Cursor 

@ScriptedAlchemy ScriptedAlchemy merged commit 941eabb into main Mar 6, 2026
24 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the cursor/nx-executor-migration-9e4b branch March 6, 2026 00:11
@2heal1 2heal1 mentioned this pull request Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants