Conversation
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/data-prefetch
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/modern-js-v3
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 852fa01988
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| chunkIds: 'named', | ||
| moduleIds: 'named', | ||
| }, | ||
| output: { |
There was a problem hiding this comment.
Merge duplicated
output config into one object
This fixture declares output twice in the same object literal, so the second block overrides the first and ignoreBrowserWarnings: true is never applied. That silently drops the warning-suppression behavior this test case appears to rely on, making the case vulnerable to unrelated browser-warning noise instead of only validating share-scope behavior.
Useful? React with 👍 / 👎.
| "type": "dir-section-header", | ||
| "name": "advanced", | ||
| "label": "高级能力" |
There was a problem hiding this comment.
Add Chinese
advanced/_meta.json for new docs section
The Chinese guide now references an advanced section, but there is no apps/website-new/docs/zh/guide/advanced/_meta.json to register pages in that directory (checked with rg --files apps/website-new/docs/zh/guide). In this docs tree, mdx-containing directories use _meta.json for sidebar entries, so the new multiple-shared-scope page is likely not discoverable from the zh navigation.
Useful? React with 👍 / 👎.
Bundle Size ReportNo bundle size changes detected. Total dist: 6.89 MB (no change) |
Description
Related Issue
Types of changes
Checklist