feat: tsup build alignment and local setup fixes#4460
Merged
ScriptedAlchemy merged 74 commits intomainfrom Feb 28, 2026
Merged
Conversation
Co-authored-by: zackary.l.jackson <zackary.l.jackson@gmail.com>
Use tsdown with nx run-commands for migrated packages and align export and type outputs for publint. Remove legacy rollup configs and add shared migration scaffolding. Co-authored-by: Cursor <cursoragent@cursor.com>
Align package build metadata with tsdown output and type extension updates. Remove CJS fallback from ESM runtime alias resolution for consistent module format selection. Co-authored-by: Cursor <cursoragent@cursor.com>
Use .d.mts for import types so exports match emitted ESM declaration files. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ScriptedAlchemy
commented
Feb 27, 2026
ScriptedAlchemy
commented
Feb 27, 2026
packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Outdated
Show resolved
Hide resolved
ScriptedAlchemy
commented
Feb 27, 2026
# Conflicts: # .cursorignore
ScriptedAlchemy
commented
Feb 28, 2026
| const runtimePath = path.resolve(__dirname, './plugin.esm.js'); | ||
| const runtimePluginCandidates = | ||
| process.env.IS_ESM_BUILD === 'true' | ||
| ? ['../plugin.js', '../plugin.cjs'] |
Member
Author
There was a problem hiding this comment.
why do we have to do this id we have esm and cjs already why cant paths just be corerct? isnt this both cjs and esm build output?
ScriptedAlchemy
commented
Feb 28, 2026
|
|
||
| // Keep legacy dist entry names as fallbacks for mixed plugin/runtime versions. | ||
| // Resolve package root last to avoid accidentally selecting a CJS export when | ||
| // an explicit ESM fallback file exists in legacy runtime layouts. |
Member
Author
There was a problem hiding this comment.
instad of checking based on bnudler conditions, since this package uses tsdown and it ahs define for its esm and cjs build outputs, cant we use that to conditionally proces.env.SI_ESM_BUILD to set the assets for the esm version aand cjs version fo the libary build outpus instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Single-PR Review Guide (No Additional PRs)
This PR will remain a single PR. Improvements are being done in-place (no stacked or follow-up PR splitting).
Suggested Review Order
In-Place Scope Trim Checklist