chore(module-federation): add pkg.pr.new preview workflow#4422
chore(module-federation): add pkg.pr.new preview workflow#4422ScriptedAlchemy merged 5 commits intomainfrom
Conversation
Add a PR preview workflow that publishes only Changesets fixed packages. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 693f70aa7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
.github/workflows/pkg-pr-new.yml
Outdated
| run: pnpm install --frozen-lockfile | ||
|
|
||
| - name: Build package workspace targets | ||
| run: npx nx run-many --targets=build --projects=tag:type:pkg --skip-nx-cache |
There was a problem hiding this comment.
Build metro fixed-set packages before publishing previews
publish-preview builds only --projects=tag:type:pkg, but the publish step includes every package in the Changesets fixed set, which currently includes @module-federation/metro, @module-federation/metro-plugin-rnef, and @module-federation/metro-plugin-rnc-cli from .changeset/config.json. The first two are tagged type:metro (see their project.json) and rely on generated dist outputs in package.json (main/files point to dist/*), so they are not built by this workflow before publish; this makes metro preview artifacts incomplete or broken whenever this workflow runs.
Useful? React with 👍 / 👎.
Bundle Size ReportNo bundle size changes detected. Total dist: 6.66 MB (no change) |
Retry package build once to reduce transient dts build failures in preview workflow. Co-authored-by: Cursor <cursoragent@cursor.com>
Mirror cache and cleanup setup from checkout-install to reduce CI drift. Co-authored-by: Cursor <cursoragent@cursor.com>
Treat missing pkg.pr.new app as a non-blocking skip and keep other publish failures blocking. Co-authored-by: Cursor <cursoragent@cursor.com>
Add SC2016 suppression for embedded node script in pkg preview workflow. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
pkg.pr.newGitHub Actions workflow for pull requestsfixedsynced setTest plan
Made with Cursor