Conversation
🦋 Changeset detectedLatest commit: 30b9ce0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 619f80030c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (typeof document === 'undefined') { | ||
| return null; |
There was a problem hiding this comment.
Prevent hydration mismatch in the NoSSR wrapper
This guard makes server output and first client render diverge in every SSG/SSR page that uses NoSSR (document is undefined on the server but defined during hydration), so React hydrates mismatched markup and may recover by discarding pre-rendered content for that subtree. In practice this defeats the purpose of SSG for wrapped content and can produce hydration warnings/flicker; the wrapper needs a mounted-state gate (or the framework-provided NoSSR behavior) so initial client render also returns null.
Useful? React with 👍 / 👎.
| 'react-router-dom': { | ||
| singleton: true, | ||
| requiredVersion: false, |
There was a problem hiding this comment.
Declare react-router-dom before auto-sharing it
Adding react-router-dom to the default shared map makes Module Federation resolve it from the consumer app, but this package does not declare that requirement. Consumers that only install @rspress/core (especially with strict package managers like pnpm) can now fail build-time resolution with Can't resolve 'react-router-dom' after upgrading, because the module is not guaranteed to exist at the app root unless explicitly declared.
Useful? React with 👍 / 👎.
619f800 to
03c22fa
Compare
Bundle Size Report2 package(s) changed, 36 unchanged.
Total dist: 6.66 MB (+1.6 kB (+0.0%)) |
iOS Release APP for simulatorsNote: if the download link expires, please re-run the workflow to generate a new build. Generated at 2026-02-12T02:40:34.663Z UTC |
ea942fe to
30b9ce0
Compare
Android Release APK for all devicesNote: if the download link expires, please re-run the workflow to generate a new build. Generated at 2026-02-12T02:28:39.671Z UTC |
Description
support ssg-md
Related Issue
Types of changes
Checklist