Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle Size ReportNo bundle size changes detected. Total dist: 4.95 MB (no change) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c91e18164c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return; | ||
| } | ||
| await runShell( | ||
| 'npx nx run-many --target=serve --projects=node-local-remote,node-remote,node-dynamic-remote-new-version,node-dynamic-remote --parallel=10 & echo "done" && sleep 25 && npx nx run-many --target=serve --projects=node-host & sleep 5 && npx wait-on tcp:3333 && npx nx run node-host-e2e:test:e2e', |
There was a problem hiding this comment.
Terminate federation servers after e2e-node test run
This step starts multiple nx ... --target=serve processes in the background (&) but never stops them, so pnpm ci:local leaves long-lived Node servers running even when the job succeeds. Because this script runs jobs sequentially in one local machine (unlike isolated GitHub runners), those orphaned processes can consume resources and cause later local runs to fail with occupied ports or flaky behavior.
Useful? React with 👍 / 👎.
| return; | ||
| } | ||
| await runShell( | ||
| 'lsof -ti tcp:3050,3051,3052,3053,3054,3055,3056 | xargs -r kill && pnpm run app:modern:dev & sleep 30 && for port in 3050 3051 3052 3053 3054 3055 3056; do while true; do response=$(curl -s http://127.0.0.1:$port/mf-manifest.json); if echo "$response" | jq empty >/dev/null 2>&1; then break; fi; sleep 1; done; done', |
There was a problem hiding this comment.
Stop Modern SSR dev servers after readiness check
This command launches pnpm run app:modern:dev in the background and exits once manifests are readable, but there is no teardown afterward, so the dev servers keep running after the job finishes. In the local sequential runner this leaks processes and ports between jobs/reruns, which can make subsequent ci:local executions fail or behave inconsistently.
Useful? React with 👍 / 👎.
Description
Introduces a
pnpm ci:localcommand to enable local simulation of CI workflows. This script (tools/scripts/ci-local.mjs) sequentially executes a subset of CI jobs, mirroring the GitHub Actions setup. It allows developers to test changes locally, reducing reliance on remote CI runs for faster iteration and debugging.The command supports:
--list: To view all available jobs.--only=job1,job2: To run specific jobs.It explicitly skips metro-related jobs and GitHub-only actions like
actionlintandbundle-size-comment.Related Issue
N/A
Types of changes
Checklist