fix(dts-plugin): fix Windows type generation#4382
Merged
ScriptedAlchemy merged 10 commits intomainfrom Feb 9, 2026
Merged
Conversation
|
Cursor Agent can help with this pull request. Just |
🦋 Changeset detectedLatest commit: 3940efe The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Bundle Size Report1 package(s) changed, 37 unchanged.
Total dist: 6.38 MB (+7.1 kB (+0.1%)) |
…y-configuration-3ee2
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c48bf69b0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Document the Windows type generation fix in a changeset for release notes. Co-authored-by: Cursor <cursoragent@cursor.com>
…m:module-federation/core into cursor/shared-property-configuration-3ee2
Split compilerInstance into argv tokens for execFile and cover it with a unit test. Co-authored-by: Cursor <cursoragent@cursor.com>
…y-configuration-3ee2
2heal1
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Windows failures in
@module-federation/dts-pluginby invoking the compiler withexecFileand passing arguments as an array, avoiding single-quote path issues incmd.exe. The displayed command now uses a safely quoted project path for copy/paste.Related Issue
#4272
Types of changes
Checklist