Skip to content

Ci issues resolution#4381

Merged
ScriptedAlchemy merged 3 commits intorslib/runtime-pluginsfrom
cursor/ci-issues-resolution-da8e
Feb 8, 2026
Merged

Ci issues resolution#4381
ScriptedAlchemy merged 3 commits intorslib/runtime-pluginsfrom
cursor/ci-issues-resolution-da8e

Conversation

@ScriptedAlchemy
Copy link
Copy Markdown
Member

@ScriptedAlchemy ScriptedAlchemy commented Feb 8, 2026

Description

Fixes an issue where the tools/scripts/ci-is-affected.mjs script was incorrectly determining affected projects, leading to all e2e CI jobs running unnecessarily. This was due to:

  1. Not passing --base and --head arguments to npx nx show projects --affected.
  2. Casting the final boolean result to a string, which made the if (isAffected) check always truthy.

This PR updates the script to correctly pass base/head (prioritizing NX_BASE/NX_HEAD environment variables) to the nx command and properly parse its output to derive a true boolean isAffected value. This ensures that e2e CI jobs are only triggered when relevant projects are actually affected.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Open in Cursor Open in Web

@cursor
Copy link
Copy Markdown

cursor bot commented Feb 8, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 8, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1ad763a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review February 8, 2026 03:14
@ScriptedAlchemy ScriptedAlchemy merged commit db0ba06 into rslib/runtime-plugins Feb 8, 2026
13 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the cursor/ci-issues-resolution-da8e branch February 8, 2026 03:14
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Feb 8, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ad763a4d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

.github/workflows/e2e-modern.yml

- name: Run condition check script
id: check-ci
continue-on-error: true
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Surface affected-project detection failures

Setting continue-on-error: true here means any non-zero exit from ci-is-affected.mjs is treated as non-fatal, and the next gate (if: steps.check-ci.outcome == 'success') will just skip E2E. Because the script returns non-zero not only for "unaffected" apps but also when npx nx show projects --affected ... fails (for example, bad SHAs or an Nx execution error), this change can turn real CI failures into green jobs where tests never ran.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ScriptedAlchemy @cursoragent