[Chore]: Use manifest passed in options#4332
Merged
zhoushaw merged 3 commits intomodule-federation:mainfrom Mar 9, 2026
Merged
[Chore]: Use manifest passed in options#4332zhoushaw merged 3 commits intomodule-federation:mainfrom
zhoushaw merged 3 commits intomodule-federation:mainfrom
Conversation
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
zhoushaw
approved these changes
Mar 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Title: feat: Allow spreading of manifest options in NextFederationPlugin
Refactors how the
manifestconfiguration is built inNextFederationPluginso that user-provided manifest options are merged with the plugin’s defaults instead of being ignored.Previously, the plugin only set a conditional
manifestobject withfilePathbased onisServer(empty string for server,/static/chunksfor client). Anymanifestoptions passed into the plugin were not used.Changes:
manifestobject into the underlying configuration.this._options.manifestare spread first:...(this._options.manifest ?? {}).filePathis set after the spread so the existing behavior is preserved:filePath: isServer ? '' : '/static/chunks'.This lets users pass custom manifest options (e.g.
name,publicPath) while the plugin still controlsfilePathbased on server vs client. The change is non-breaking and follows the same merge pattern used forshared,remotes, andexposes.Related Issue
#4333
Types of changes
Checklist