fix(enhanced): remove normal module replacement of runtime#3652
Merged
ScriptedAlchemy merged 3 commits intomainfrom Apr 1, 2025
Merged
fix(enhanced): remove normal module replacement of runtime#3652ScriptedAlchemy merged 3 commits intomainfrom
ScriptedAlchemy merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: d340d2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2f2aab5 to
ec740dc
Compare
2heal1
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
FederationRuntimePluginclass in thepackages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.tsfile. The most important change involves the removal of theNormalModuleReplacementPluginsetup.Codebase simplification:
packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts: Removed the setup forNormalModuleReplacementPluginthat was replacing the module federation runtime path based on the issuer context. This change simplifies the plugin application process and removes unnecessary complexity.Description
Related Issue
Types of changes
Checklist