Skip to content

fix: enable SSR by utilizing pluginOptions and configuration#3516

Merged
2heal1 merged 1 commit intomodule-federation:mainfrom
caohuilin:fix/enable-ssr
Feb 17, 2025
Merged

fix: enable SSR by utilizing pluginOptions and configuration#3516
2heal1 merged 1 commit intomodule-federation:mainfrom
caohuilin:fix/enable-ssr

Conversation

@caohuilin
Copy link
Copy Markdown
Contributor

@caohuilin caohuilin commented Feb 13, 2025 •
edited
Loading

Description

Modern.js ssr plugin check enableSSR:

const enableSSR = pluginOptions.userConfig?.ssr === false ? false : Boolean(modernjsConfig?.server?.ssr);

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: b071306

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@module-federation/modern-js Patch
@module-federation/runtime Patch
@module-federation/enhanced Patch
@module-federation/rspack Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/rsbuild-plugin Patch
@module-federation/error-codes Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/esbuild Patch
@module-federation/runtime-core Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 13, 2025 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit b071306
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67ad976067910d0008695e59
😎 Deploy Preview https://deploy-preview-3516--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@caohuilin caohuilin changed the title fix: enable SSR by utilizing pluginOptions and configuration adjustme… fix: enable SSR by utilizing pluginOptions and configuration Feb 13, 2025
@2heal1 2heal1 merged commit e602d82 into module-federation:main Feb 17, 2025
19 checks passed
@2heal1 2heal1 mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2heal1 2heal1 2heal1 approved these changes

+1 more reviewer

@KyrieLii KyrieLii KyrieLii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caohuilin @KyrieLii @2heal1