Skip to content

fix(dts-plugin): optimize generate types in dev#3450

Merged
2heal1 merged 7 commits intomainfrom
perf/dts-output
Feb 19, 2025
Merged

fix(dts-plugin): optimize generate types in dev#3450
2heal1 merged 7 commits intomainfrom
perf/dts-output

Conversation

@2heal1
Copy link
Copy Markdown
Member

@2heal1 2heal1 commented Jan 21, 2025

Description

dts generate should not block main build process when in dev

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d62ed56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@module-federation/dts-plugin Patch
@module-federation/enhanced Patch
@module-federation/manifest Patch
@module-federation/rspack Patch
@module-federation/modern-js Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/rsbuild-plugin Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/runtime Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/error-codes Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/esbuild Patch
@module-federation/runtime-core Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit d62ed56
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67b568006787fd00087ea747
😎 Deploy Preview https://deploy-preview-3450--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2heal1 2heal1 changed the title perf(dts-plugin): only block build process in prod env when generating types fix: only block build process in prod env when generating types Jan 21, 2025
@2heal1 2heal1 changed the title fix: only block build process in prod env when generating types fix(dts-plugin): only block build process in prod env when generating types Jan 21, 2025
@2heal1 2heal1 changed the title fix(dts-plugin): only block build process in prod env when generating types fix: only block build process in prod env when generating types Jan 21, 2025
@2heal1 2heal1 changed the title fix: only block build process in prod env when generating types fix(dts-plugin): only block build process in prod env when generating types Jan 21, 2025
@2heal1 2heal1 changed the title fix(dts-plugin): only block build process in prod env when generating types fix(dts-plugin): optimize generate types in dev Jan 21, 2025
@2heal1 2heal1 changed the title fix(dts-plugin): optimize generate types in dev fix: optimize generate types in dev Jan 21, 2025
@2heal1 2heal1 changed the title fix: optimize generate types in dev WIPfix: optimize generate types in dev Jan 21, 2025
@2heal1 2heal1 changed the title WIPfix: optimize generate types in dev WIP: fix: optimize generate types in dev Jan 21, 2025
@2heal1 2heal1 changed the title WIP: fix: optimize generate types in dev WIP: fix(dts-plugin): optimize generate types in dev Jan 21, 2025
@2heal1 2heal1 changed the title WIP: fix(dts-plugin): optimize generate types in dev fix(dts-plugin): optimize generate types in dev Jan 21, 2025
@2heal1 2heal1 changed the title fix(dts-plugin): optimize generate types in dev fix: optimize generate types in dev Jan 21, 2025
@2heal1 2heal1 changed the title fix: optimize generate types in dev fix(dts-plugin): optimize generate types in dev Jan 22, 2025
@2heal1
Copy link
Copy Markdown
Member Author

2heal1 commented Jan 22, 2025 •
edited
Loading

@zhoushaw need to add github_token PullRequests write , otherwise the PR_label is always failed

@KyrieLii
Copy link
Copy Markdown
Member

KyrieLii commented Feb 8, 2025

@zhoushaw need to add github_token PullRequests write , otherwise the PR_label is always failed

Fixed :) #3484

@2heal1 2heal1 merged commit d227303 into main Feb 19, 2025
16 checks passed
@2heal1 2heal1 deleted the perf/dts-output branch February 19, 2025 06:01
@2heal1 2heal1 mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScriptedAlchemy ScriptedAlchemy ScriptedAlchemy approved these changes

@zhoushaw zhoushaw zhoushaw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@2heal1 @KyrieLii @ScriptedAlchemy @zhoushaw