fix(dts-plugin): auto inject compiler output path to avoid duplicate zip file#3401
Merged
fix(dts-plugin): auto inject compiler output path to avoid duplicate zip file#3401
Conversation
🦋 Changeset detectedLatest commit: 272bd38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zhoushaw
approved these changes
Dec 26, 2024
Merged
mcroba
reviewed
Jan 6, 2025
| context: compiler.context, | ||
| outputDir: path.relative( | ||
| compiler.context, | ||
| compiler.outputPath || compiler.options.output.path, |
There was a problem hiding this comment.
@zhoushaw I have found an issue when I don't have any path defined in my config.
Shouldn't we have a fallback to dist (default value) here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
auto inject compiler output path to avoid duplicate zip file
if compiler.options.output is
dist/mf, it generated zip file on dist and dist/mf before . Now add compiler.output.path to avoid this .before:
after:
Related Issue
Types of changes
Checklist