Skip to content

feat(dts-plugin): allow users to specify a cwd to generate the types#3339

Merged
2heal1 merged 5 commits intomodule-federation:mainfrom
nachoaldamav:main
Dec 12, 2024
Merged

feat(dts-plugin): allow users to specify a cwd to generate the types#3339
2heal1 merged 5 commits intomodule-federation:mainfrom
nachoaldamav:main

Conversation

@nachoaldamav
Copy link
Copy Markdown
Contributor

@nachoaldamav nachoaldamav commented Dec 10, 2024

Description

This PR adds a new property to the dts types that allows to pass a custom Current Work Directory to be used by exec to generate the types. It allows to generate types in environments where the user is running the plugin in a place where the Current Work Directory does not have Typescript installed.

Related Issue

#3338

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 9bdc55e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 10, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 9bdc55e
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6758228dae74b10008aa0766
😎 Deploy Preview https://deploy-preview-3339--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nachoaldamav nachoaldamav marked this pull request as ready for review December 10, 2024 11:14
@2heal1 2heal1 merged commit 8e172c8 into module-federation:main Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants