fix(runtime): add @vite-ignore for dynamic import in loadEsmEntry#3251
Merged
ScriptedAlchemy merged 4 commits intomodule-federation:mainfrom Nov 25, 2024
Merged
fix(runtime): add @vite-ignore for dynamic import in loadEsmEntry#3251ScriptedAlchemy merged 4 commits intomodule-federation:mainfrom
ScriptedAlchemy merged 4 commits intomodule-federation:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 7199bd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Hi @ScriptedAlchemy, Could you take a look at the PR? It's similar to yours #3054. |
Member
|
Will do. Probably tomorrow |
ScriptedAlchemy
approved these changes
Nov 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The runtime package uses a dynamic ESM import. It already has
webpackIgnoreto avoid bundler modifications (added in #3054).This PR adds a similar
/* @vite-ignore */comment for Vite.Related Issue
#3250
Types of changes
Checklist