fix(dts-plugin): hold the broker server if the remote not start locally#3202
fix(dts-plugin): hold the broker server if the remote not start locally#3202
Conversation
🦋 Changeset detectedLatest commit: 3d39737 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Summary
The pull request introduces a fix to the dts-plugin package, addressing an issue where the broker server would not hold if the remote failed to start locally. The changes capture the connection failure event and hold the broker server, providing a more informative error message to the user.
The key changes include:
- Implementing a new error handling mechanism in the
ModuleFederationDevServerclass to capture the connection failure event. - Holding the broker server if the remote fails to start locally, ensuring a better user experience.
- Updating the documentation to reflect the new changes.
These improvements to the dts-plugin package will enhance the overall reliability and usability of the Module Federation core functionality.
File Summaries
| File | Summary |
|---|---|
| packages/dts-plugin/src/server/DevServer.ts | The code changes introduce a new error handling mechanism for the remote connection in the ModuleFederationDevServer class. It captures the connection failure event and holds the broker server if the remote fails to start locally, providing a more informative error message to the user. |
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
1a80706ba5c93baff5a880ff401540835d48e897...3d39737b434076fbef301871bf52e1e5fcb22217
Files Reviewed
- packages/dts-plugin/src/server/DevServer.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/fair-plums-live.md
Description
capture connection failure event, hold the broker server if the remote not start locally
Related Issue
#3201
Types of changes
Checklist