Skip to content

fix(rsbuild-plugin): failed to load remote modules with server.base#3102

Merged
nyqykk merged 1 commit intomodule-federation:mainfrom
chenjiahan:rsbuild_plugin_base_1022
Oct 22, 2024
Merged

fix(rsbuild-plugin): failed to load remote modules with server.base#3102
nyqykk merged 1 commit intomodule-federation:mainfrom
chenjiahan:rsbuild_plugin_base_1022

Conversation

@chenjiahan
Copy link
Copy Markdown
Contributor

Description

Fix failed to load MF remote modules when using server.base.

The default dev.assetPrefix is set to the value of server.base, and Rsbuild should replace it with dev.assetPrefix: true to ensure that the remote module's assets can be requested by consumer apps with the correct URL.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: b2a3329

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 22, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit b2a3329
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6717388393970d0008886ac8
😎 Deploy Preview https://deploy-preview-3102--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nyqykk nyqykk merged commit 3ac3fc8 into module-federation:main Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Module Federation - Remote app fails to load when running with a base path

2 participants