-
-
Notifications
You must be signed in to change notification settings - Fork 400
Closed
Description
Describe the bug
Packages
@module-federation/rsbuild-plugin
Description
in commit 95be7e8#diff-5ee5efd88d835533c55cc15b806482c0b87c4c979df54ce195f0c32063cf43a5
there was change of parameter RSBUILD_PLUGIN_OPTIONS type from optional to necessary
but in module federation docs
it is optional.
export declare const pluginModuleFederation: (moduleFederationOptions: ModuleFederationOptions, rsbuildOptions?: RSBUILD_PLUGIN_OPTIONS) => RsbuildPlugin;
type RSBUILD_PLUGIN_OPTIONS = {
ssr?: boolean;
}is there a reason of change? i think it should be optional as it was.
Reproduction
can reproduce through pnpm create module-federation@latest
Used Package Manager
pnpm
System Info
System:
OS: macOS 15.5
CPU: (10) arm64 Apple M1 Max
Memory: 808.92 MB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
pnpm: 10.10.0 - ~/.nvm/versions/node/v20.11.0/bin/pnpm
Browsers:
Chrome: 138.0.7204.93
Edge: 138.0.3351.65
Safari: 18.5
Safari Technology Preview: 26.0Validations
- Read the docs.
- Read the common issues list.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Make sure this is a Module federation issue and not a framework-specific issue.
- The provided reproduction is a minimal reproducible example of the bug.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels