Skip to content

#222 Use ZipFile API to set timestamps#230

Merged
aalmiray merged 1 commit intomoditect:mainfrom
aalmiray:gh222/reproducible-timestamp
Feb 11, 2024
Merged

#222 Use ZipFile API to set timestamps#230
aalmiray merged 1 commit intomoditect:mainfrom
aalmiray:gh222/reproducible-timestamp

Conversation

@aalmiray
Copy link
Copy Markdown
Contributor

@aalmiray aalmiray commented Feb 8, 2024

Fixes #222

@aalmiray
Copy link
Copy Markdown
Contributor Author

aalmiray commented Feb 8, 2024

@hboutemy, @ppkarwasz Here's the first attempt. All tests are green.

Copy link
Copy Markdown

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except some small remarks.

Comment thread core/src/main/java/org/moditect/commands/AddModuleInfo.java Outdated
Comment thread core/src/main/java/org/moditect/commands/AddModuleInfo.java Outdated
@aalmiray aalmiray force-pushed the gh222/reproducible-timestamp branch from 97fcf3f to 0254f5e Compare February 9, 2024 10:49
Copy link
Copy Markdown

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated JAR file depends on default time zone

2 participants