Avoid fragile Java version parsing when looking for module-info.java#163
Merged
gunnarmorling merged 2 commits intomoditect:mainfrom Jul 27, 2022
Merged
Avoid fragile Java version parsing when looking for module-info.java#163gunnarmorling merged 2 commits intomoditect:mainfrom
gunnarmorling merged 2 commits intomoditect:mainfrom
Conversation
Relates to moditect#158, but most likely does not fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162
Tested locally with JDK 17-ea+35, 11.0.13 and 17.0.2. It worked in all cases. Can't say for other JDKs, or when
--multi-releaseis not used; I suppose CI should tell us that much.