Skip to content

Update JReleaser configuration with changelog formatting options#153

Merged
gunnarmorling merged 1 commit intomoditect:masterfrom
aalmiray:jreleaser-update-config
Oct 4, 2021
Merged

Update JReleaser configuration with changelog formatting options#153
gunnarmorling merged 1 commit intomoditect:masterfrom
aalmiray:jreleaser-update-config

Conversation

@aalmiray
Copy link
Copy Markdown
Contributor

@aalmiray aalmiray commented Oct 4, 2021

No description provided.

@gunnarmorling gunnarmorling merged commit 7ad284e into moditect:master Oct 4, 2021
@gunnarmorling
Copy link
Copy Markdown
Member

Rebased and applied. Thanks, @aalmiray! The failure was stemming from the fact that the POMs were still at 1.0.0.CR2 instead of -SNAPSHOT. Wondering whether this shouldn't be part of the release job, too?

@aalmiray aalmiray deleted the jreleaser-update-config branch October 4, 2021 12:55
@aalmiray
Copy link
Copy Markdown
Contributor Author

aalmiray commented Oct 4, 2021

Ah yes, likely. Wonder if we could use https://www.mojohaus.org/versions-maven-plugin/use-next-snapshots-mojo.html to figure out the number automatically.

@gunnarmorling
Copy link
Copy Markdown
Member

Ah, yes, why not. I also wouldn't mind if it simply was another parameter to the trigger job.

@aalmiray
Copy link
Copy Markdown
Contributor Author

aalmiray commented Oct 4, 2021

I think kcctl already has something like that https://github.com/kcctl/kcctl/blob/93e60e967189642747f90b512668db46c0273a77/.github/workflows/release.yml#L19-L27

Except in this case both trigger and release are found in a single workflow file and share intermediate files using artifact upload/download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants