Skip to content

AddModuleInfo does not generate reproducible archives #185

@aalmiray

Description

@aalmiray

The org.moditect.commands.AddModuleInfo class does not generate reproducible archives because the module-info.class entry does not have a timestamp matching the rest of the archive which might have been configured as reproducible.

public AddModuleInfo(String moduleInfoSource, String mainClass, String version, Path inputJar, Path outputDirectory, String jvmVersion, boolean overwriteExistingFiles) {
should take an additional parameter with the given timestamp, defaulting to the begin of the epoch.

Follow the same behavior when parsing the timestamp as https://github.com/apache/maven-archiver/blob/0f66795c8d1cbcc9f767b6e23b72e029040481b7/src/main/java/org/apache/maven/archiver/MavenArchiver.java#L862-L901

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions