Replace read_pandas with ParquetDataset to support predicate pushdown#638
Merged
devin-petersohn merged 2 commits intomodin-project:masterfrom May 25, 2019
Merged
Replace read_pandas with ParquetDataset to support predicate pushdown#638devin-petersohn merged 2 commits intomodin-project:masterfrom
devin-petersohn merged 2 commits intomodin-project:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
=======================================
Coverage 90.43% 90.43%
=======================================
Files 37 37
Lines 5552 5552
=======================================
Hits 5021 5021
Misses 531 531
Continue to review full report at Codecov.
|
3 tasks
devin-petersohn
approved these changes
May 25, 2019
Collaborator
devin-petersohn
left a comment
There was a problem hiding this comment.
Looks great, thanks @ddutt!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… on parquet
What do these changes do?
The change allows you to use predicate pushdown with parquet with the use of filters kwarg.
Related issue number
#636
flake8 modinblack --check modin