Update pandas version to 0.24 by devin-petersohn · Pull Request #451 · modin-project/modin

devin-petersohn · 2019-02-03T16:36:41Z

pandas release notes: http://pandas.pydata.org/pandas-docs/stable/whatsnew/v0.24.0.html
Update imports to match changes in pandas
Add functionality for list of functions on axis=1 for apply
Remove pd.match from API
Small regression in pandas requires regression in Modin
- all/any ignoring bool_only parameter pandas-dev/pandas#25101 reports this issue
- BUG: Fixing regression in DataFrame.all and DataFrame.any with bool_only=True pandas-dev/pandas#25102 resolves this issue
TODO: Expose pandas.Array once we properly test

What do these changes do?

Related issue number

passes git diff upstream/master -u -- "*.py" | flake8 --diff
passes black --check modin/

AmplabJenkins · 2019-02-03T16:43:01Z

Merged build finished. Test PASSed.

AmplabJenkins · 2019-02-03T16:43:01Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/422/
Test PASSed.

AmplabJenkins · 2019-02-03T16:43:04Z

Merged build finished. Test PASSed.

AmplabJenkins · 2019-02-03T16:43:05Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/361/
Test PASSed.

AmplabJenkins · 2019-02-03T16:47:13Z

Merged build finished. Test PASSed.

AmplabJenkins · 2019-02-03T16:47:14Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/362/
Test PASSed.

AmplabJenkins · 2019-02-03T17:07:38Z

Merged build finished. Test PASSed.

AmplabJenkins · 2019-02-03T17:07:39Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/423/
Test PASSed.

AmplabJenkins · 2019-02-07T19:54:11Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-07T19:54:12Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/485/
Test FAILed.

codecov · 2019-02-07T20:26:54Z

Codecov Report

Merging #451 into master will increase coverage by 2.02%.
The diff coverage is 98.79%.

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   83.74%   85.76%   +2.02%     
==========================================
  Files          34       34              
  Lines        4669     4651      -18     
==========================================
+ Hits         3910     3989      +79     
+ Misses        759      662      -97

Impacted Files	Coverage Δ
modin/engines/base/io.py	`90.24% <ø> (ø)`	⬆️
...management/query_compiler/pandas_query_compiler.py	`85.45% <100%> (-0.02%)`	⬇️
modin/pandas/__init__.py	`78.84% <100%> (+12.17%)`	⬆️
modin/pandas/dataframe.py	`88.45% <98.61%> (+5.66%)`	⬆️
...odin/engines/ray/pandas_on_ray/remote_partition.py	`75% <0%> (-1%)`	⬇️
modin/data_management/utils.py	`84.44% <0%> (-0.67%)`	⬇️
...ngines/python/pandas_on_python/remote_partition.py	`86% <0%> (-0.28%)`	⬇️
modin/pandas/groupby.py	`88.26% <0%> (-0.06%)`	⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226c705...f4c92d2. Read the comment docs.

AmplabJenkins · 2019-02-08T21:52:39Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-08T21:52:40Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/493/
Test FAILed.

AmplabJenkins · 2019-02-09T08:48:30Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-09T08:48:31Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/497/
Test FAILed.

AmplabJenkins · 2019-02-16T23:52:15Z

Build finished. Test FAILed.

AmplabJenkins · 2019-02-16T23:52:15Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/524/
Test FAILed.

AmplabJenkins · 2019-02-17T23:22:25Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-17T23:22:26Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/531/
Test FAILed.

AmplabJenkins · 2019-02-18T02:32:27Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-18T02:32:28Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/533/
Test FAILed.

AmplabJenkins · 2019-02-18T03:13:51Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-18T03:13:51Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/534/
Test FAILed.

AmplabJenkins · 2019-02-19T16:07:50Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-19T16:07:52Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/535/
Test FAILed.

AmplabJenkins · 2019-02-19T17:47:46Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-19T17:47:48Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/536/
Test FAILed.

AmplabJenkins · 2019-02-19T19:13:59Z

Merged build finished. Test FAILed.

* pandas release notes: http://pandas.pydata.org/pandas-docs/stable/whatsnew/v0.24.0.html * Update imports to match changes in pandas * Add functionality for list of functions on `axis=1` for `apply` * Remove `pd.match` from API * Small regression in pandas requires regression in Modin * pandas-dev/pandas#25101 reports this issue * pandas-dev/pandas#25102 resolves this issue * TODO: Expose `pandas.Array` once we properly test

AmplabJenkins · 2019-02-20T01:57:17Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-20T01:57:18Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/539/
Test FAILed.

williamma12

Great work! Just one small question

williamma12 · 2019-02-20T04:00:21Z

modin/pandas/test/test_dataframe.py

+        [("c", "e"), ("d", "f")], names=["level_1", "level_2"]
+    )
+
+    print(df)


Do we need a print statement here?

AmplabJenkins · 2019-02-20T15:17:41Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-20T15:17:43Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/540/
Test FAILed.

williamma12

Thanks for the changes @devin-petersohn!

AmplabJenkins · 2019-02-21T02:03:54Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-21T02:03:55Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/541/
Test FAILed.

AmplabJenkins · 2019-02-21T06:58:50Z

Merged build finished. Test FAILed.

AmplabJenkins · 2019-02-21T06:58:51Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/542/
Test FAILed.

devin-petersohn force-pushed the pandas/0.24_compat branch from ffabbc8 to 466c6ac Compare February 7, 2019 19:51

devin-petersohn force-pushed the pandas/0.24_compat branch from ac169e1 to 6f33114 Compare February 17, 2019 23:22

devin-petersohn added 12 commits February 19, 2019 17:55

Finishing regression update in all/any

d3a94f9

Update to pandas 0.24 in setup.py and requirements.txt

49de77b

Bump to 0.24.1

5e308de

Update API and add a test for the API

c12c1fe

Add test for API, update API

0844948

Update API test and finalize compatibility updates

81758fc

Revert bug

2c39cdc

Cleanup and add tests

44c0825

Fix bug in test

d7724da

Lint

adb16e1

Lint

94576a4

devin-petersohn force-pushed the pandas/0.24_compat branch from 40ba9c0 to 94576a4 Compare February 20, 2019 01:56

williamma12 reviewed Feb 20, 2019

View reviewed changes

devin-petersohn mentioned this pull request Feb 20, 2019

Import Modin Fails with ImportError: cannot import name 'match' from 'pandas' #475

Closed

Remove print

7f661a5

williamma12 approved these changes Feb 20, 2019

View reviewed changes

devin-petersohn added 2 commits February 20, 2019 17:56

Fix transform tests and bug in transform

b000e07

Add list test for test_rename

6f62244

Fix transform bug

f4c92d2

devin-petersohn merged commit 5b861c2 into modin-project:master Feb 21, 2019

Conversation

devin-petersohn commented Feb 3, 2019

What do these changes do?

Related issue number

Uh oh!

AmplabJenkins commented Feb 3, 2019

Uh oh!

AmplabJenkins commented Feb 3, 2019

Uh oh!

AmplabJenkins commented Feb 3, 2019

Uh oh!

AmplabJenkins commented Feb 3, 2019

Uh oh!

AmplabJenkins commented Feb 3, 2019

Uh oh!

AmplabJenkins commented Feb 3, 2019

Uh oh!

AmplabJenkins commented Feb 3, 2019

Uh oh!

AmplabJenkins commented Feb 3, 2019

Uh oh!

AmplabJenkins commented Feb 7, 2019

Uh oh!

AmplabJenkins commented Feb 7, 2019

Uh oh!

codecov bot commented Feb 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AmplabJenkins commented Feb 8, 2019

Uh oh!

AmplabJenkins commented Feb 8, 2019

Uh oh!

AmplabJenkins commented Feb 9, 2019

Uh oh!

AmplabJenkins commented Feb 9, 2019

Uh oh!

AmplabJenkins commented Feb 16, 2019

Uh oh!

AmplabJenkins commented Feb 16, 2019

Uh oh!

AmplabJenkins commented Feb 17, 2019

Uh oh!

AmplabJenkins commented Feb 17, 2019

Uh oh!

AmplabJenkins commented Feb 18, 2019

Uh oh!

AmplabJenkins commented Feb 18, 2019

Uh oh!

AmplabJenkins commented Feb 18, 2019

Uh oh!

AmplabJenkins commented Feb 18, 2019

Uh oh!

AmplabJenkins commented Feb 19, 2019

Uh oh!

AmplabJenkins commented Feb 19, 2019

Uh oh!

AmplabJenkins commented Feb 19, 2019

Uh oh!

AmplabJenkins commented Feb 19, 2019

Uh oh!

AmplabJenkins commented Feb 19, 2019

Uh oh!

AmplabJenkins commented Feb 20, 2019

Uh oh!

AmplabJenkins commented Feb 20, 2019

Uh oh!

williamma12 left a comment

Choose a reason for hiding this comment

Uh oh!

williamma12 Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

AmplabJenkins commented Feb 20, 2019

Uh oh!

AmplabJenkins commented Feb 20, 2019

Uh oh!

williamma12 left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 7, 2019 •

edited

Loading