FEAT-#4244: Implement dataframe exchange protocol for OmniSci#4269
Merged
YarShev merged 35 commits intomodin-project:masterfrom Mar 23, 2022
Merged
FEAT-#4244: Implement dataframe exchange protocol for OmniSci#4269YarShev merged 35 commits intomodin-project:masterfrom
YarShev merged 35 commits intomodin-project:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4269 +/- ##
===========================================
- Coverage 84.82% 60.23% -24.60%
===========================================
Files 213 218 +5
Lines 17321 17841 +520
===========================================
- Hits 14693 10747 -3946
- Misses 2628 7094 +4466
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…niSci Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
fb32aeb to
aa1cfc5
Compare
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
YarShev
reviewed
Mar 14, 2022
modin/experimental/core/storage_formats/omnisci/query_compiler.py
Outdated
Show resolved
Hide resolved
...core/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/utils.py
Show resolved
Hide resolved
...core/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/utils.py
Outdated
Show resolved
Hide resolved
| elif pa.types.is_date(dtype): | ||
| return getattr(ArrowCTypes, f"DATE{dtype.bit_width}", "DATE64") | ||
| elif pa.types.is_time(dtype): | ||
| # TODO: for some reason `time32` type doesn't have a `unit` attribute, |
Collaborator
There was a problem hiding this comment.
Should we ask arrow guys on this?
...ore/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/column.py
Outdated
Show resolved
Hide resolved
...ore/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/column.py
Outdated
Show resolved
Hide resolved
...ore/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/buffer.py
Outdated
Show resolved
Hide resolved
...ore/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/buffer.py
Outdated
Show resolved
Hide resolved
.../experimental/core/execution/native/implementations/omnisci_on_native/dataframe/dataframe.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
YarShev
reviewed
Mar 17, 2022
Collaborator
YarShev
left a comment
There was a problem hiding this comment.
Add a release note please.
modin/core/dataframe/pandas/exchange/dataframe_protocol/from_dataframe.py
Outdated
Show resolved
Hide resolved
modin/test/exchange/dataframe_protocol/omnisci/test_protocol.py
Outdated
Show resolved
Hide resolved
modin/test/exchange/dataframe_protocol/omnisci/test_protocol.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
YarShev
previously approved these changes
Mar 17, 2022
Collaborator
YarShev
left a comment
There was a problem hiding this comment.
@dchigarev, LGTM, thanks!
vnlitvinov
reviewed
Mar 21, 2022
modin/core/dataframe/pandas/exchange/dataframe_protocol/from_dataframe.py
Show resolved
Hide resolved
modin/core/dataframe/pandas/exchange/dataframe_protocol/from_dataframe.py
Outdated
Show resolved
Hide resolved
modin/core/dataframe/pandas/exchange/dataframe_protocol/from_dataframe.py
Outdated
Show resolved
Hide resolved
modin/core/dataframe/pandas/exchange/dataframe_protocol/from_dataframe.py
Outdated
Show resolved
Hide resolved
modin/core/dataframe/pandas/exchange/dataframe_protocol/from_dataframe.py
Outdated
Show resolved
Hide resolved
.../execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/dataframe.py
Outdated
Show resolved
Hide resolved
.../execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/dataframe.py
Outdated
Show resolved
Hide resolved
...core/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/utils.py
Outdated
Show resolved
Hide resolved
modin/test/exchange/dataframe_protocol/omnisci/test_protocol.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
|
This pull request introduces 1 alert when merging 718414d into 5440f08 - view on LGTM.com new alerts:
|
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
vnlitvinov
reviewed
Mar 23, 2022
modin/core/dataframe/pandas/exchange/dataframe_protocol/from_dataframe.py
Outdated
Show resolved
Hide resolved
modin/core/dataframe/pandas/exchange/dataframe_protocol/from_dataframe.py
Outdated
Show resolved
Hide resolved
modin/core/dataframe/pandas/exchange/dataframe_protocol/from_dataframe.py
Show resolved
Hide resolved
...core/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/utils.py
Outdated
Show resolved
Hide resolved
modin/test/exchange/dataframe_protocol/omnisci/test_protocol.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
vnlitvinov
reviewed
Mar 23, 2022
Collaborator
vnlitvinov
left a comment
There was a problem hiding this comment.
Almost there :)
Please also answer #4269 (comment)
.../execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/dataframe.py
Outdated
Show resolved
Hide resolved
...core/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/utils.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Vasily Litvinov <vasilij.n.litvinov@intel.com>
YarShev
reviewed
Mar 23, 2022
...ore/execution/native/implementations/omnisci_on_native/exchange/dataframe_protocol/column.py
Show resolved
Hide resolved
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
vnlitvinov
approved these changes
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitry Chigarev dmitry.chigarev@intel.com
What do these changes do?
OmnisciOnNativeDataframe:from_dataframefunction, converting DataFrame exchange object to pandas DataFrame.modin/test/exchange/dataframe_protocol/omnisci).OmnisciOnNative.from_dataframein order to satisfy the protocol's requirement. Link to the discussion about this in our PR.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date