FEAT-#626: Add to_parquet for Ray execution engine#3573
Merged
devin-petersohn merged 20 commits intomodin-project:masterfrom Nov 9, 2021
Merged
FEAT-#626: Add to_parquet for Ray execution engine#3573devin-petersohn merged 20 commits intomodin-project:masterfrom
to_parquet for Ray execution engine#3573devin-petersohn merged 20 commits intomodin-project:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3573 +/- ##
===========================================
- Coverage 85.32% 34.73% -50.59%
===========================================
Files 194 181 -13
Lines 16194 15579 -615
===========================================
- Hits 13818 5412 -8406
- Misses 2376 10167 +7791
Continue to review full report at Codecov.
|
8963aef to
1502828
Compare
YarShev
reviewed
Nov 2, 2021
YarShev
reviewed
Nov 3, 2021
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
e97a814 to
84698fb
Compare
to_parquet for Ray execution engine
YarShev
reviewed
Nov 8, 2021
YarShev
reviewed
Nov 9, 2021
Collaborator
YarShev
left a comment
There was a problem hiding this comment.
Left a comment. All the rest looks good.
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
YarShev
approved these changes
Nov 9, 2021
Collaborator
YarShev
left a comment
There was a problem hiding this comment.
@naren-ponder , LGTM, thanks!
devin-petersohn
approved these changes
Nov 9, 2021
Collaborator
devin-petersohn
left a comment
There was a problem hiding this comment.
LGTM, thanks for getting this in @naren-ponder!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naren Krishna naren@ponder.io
What do these changes do?
DRAFT PR IN PROGRESS
flake8 modinblack --check modingit commit -sdocs/developer/architecture.rstis up-to-date