Implement cluster spawning API#1702
Merged
vnlitvinov merged 25 commits intomodin-project:masterfrom Jul 17, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
==========================================
- Coverage 87.57% 84.04% -3.54%
==========================================
Files 72 77 +5
Lines 7391 7943 +552
==========================================
+ Hits 6473 6676 +203
- Misses 918 1267 +349
Continue to review full report at Codecov.
|
|
|
|
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
cafa2d4 to
28ca2e3
Compare
It should now die when cluster dies, so objects created in separate contexts with the same cluster are interchangeable Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
anmyachev
reviewed
Jul 13, 2020
Also make RayScale.spawn() and .destroy() call implementation immediately when wait=True Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Windows localhost is IPv6 but WSL IPv6 support is buggy Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Also change Cluster .spawn() and .destroy() to be asynchronous by default Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
anmyachev
previously approved these changes
Jul 13, 2020
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
6117240 to
8fe723f
Compare
anmyachev
previously approved these changes
Jul 13, 2020
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
devin-petersohn
requested changes
Jul 15, 2020
Collaborator
devin-petersohn
left a comment
There was a problem hiding this comment.
Thanks @vnlitvinov, this looks great! We need a couple of docstrings added and I have some suggestions on API. Please let me know your thoughts!
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Collaborator
Author
|
@devin-petersohn I hope I've addressed your API concerns. |
devin-petersohn
approved these changes
Jul 16, 2020
Collaborator
devin-petersohn
left a comment
There was a problem hiding this comment.
Looks great, thanks @vnlitvinov!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
modin.experimental.cloudpackage that will be dealing with spawning clusters in a cloudflake8 modinblack --check modingit commit -sNotes: