Skip to content

fix(test-runner-visual-regression): allow mismatched screenshot sizes to be diffed#1352

Merged
LarsDenBakker merged 2 commits intomasterfrom
westbrook/vrt-size
Mar 13, 2021
Merged

fix(test-runner-visual-regression): allow mismatched screenshot sizes to be diffed#1352
LarsDenBakker merged 2 commits intomasterfrom
westbrook/vrt-size

Conversation

@Westbrook
Copy link
Copy Markdown
Member

@Westbrook Westbrook commented Mar 12, 2021

What I did

  1. Move mismatched size error up into diff command.
  2. When images mismatch create two new images of the largest width/height from the initial screenshots.
  3. Copy the original images into the new images.
  4. Diff the synthetic screenshots.

In this was the following baseline, current, and diff screenshots will be created by the test pass:

Baseline screenshotCurrent screenshotDiff screenshot

@Westbrook Westbrook requested a review from LarsDenBakker March 12, 2021 14:32
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 12, 2021

🦋 Changeset detected

Latest commit: 21670d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@web/test-runner-visual-regression Patch
@web/test-runner Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Westbrook Westbrook force-pushed the westbrook/vrt-size branch from 3ca8ab5 to 21670d2 Compare March 12, 2021 14:47
@LarsDenBakker LarsDenBakker merged commit aea269c into master Mar 13, 2021
@LarsDenBakker LarsDenBakker deleted the westbrook/vrt-size branch March 13, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants