fix: call onerror for silently swallowed transport errors#1580
Merged
felixweinberger merged 2 commits intomodelcontextprotocol:v1.xfrom Feb 24, 2026
Merged
Conversation
|
commit: |
Fixes modelcontextprotocol#1395 - Several handleRequest error paths in WebStandardStreamableHTTPServerTransport were returning error responses via createJsonErrorResponse() without calling the onerror callback, making transport errors invisible to consumers. Added this.onerror?.() calls at 16 locations: - handleGetRequest: Missing Accept header (406), concurrent SSE stream (409) - replayEvents: Event store not configured (400), invalid event ID (400), stream conflict (409) - handlePostRequest: Invalid Accept header (406), unsupported Content-Type (415), JSON parse error (400), invalid JSON-RPC (400), re-initialization (400), multiple init requests (400) - validateSession: Server not initialized (400), missing session ID (400), session ID mismatch (404) - validateProtocolVersion: Unsupported protocol version (400) - handleUnsupportedRequest: Method not allowed (405) - writeSSEEvent: SSE write failure Added 12 test cases verifying onerror is called for each error condition.
d9dbb1b to
e270e15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1395 - Transport errors are silently swallowed due to missing
onerrorcallback invocation.Several
handleRequesterror paths inWebStandardStreamableHTTPServerTransportwere returning error responses viacreateJsonErrorResponse()without calling theonerrorcallback, making transport errors invisible to consumers who settransport.onerror.Rebased from #1576 onto
v1.xwith correct file paths.Changes
src/server/webStandardStreamableHttp.tsAdded
this.onerror?.(new Error(...))calls at 16 locations:false)test/server/streamableHttp.test.tsAdded 12 test cases verifying
onerroris called for each error condition:Pattern Used
Follows the existing pattern already present in the codebase (e.g.,
validateRequestHeaders):Testing
npm run typecheckpassesnpm test— all tests pass (existing + 12 new)npm run lintpasses