fix(server): handle undefined arguments for tools with all optional params#1404
Merged
felixweinberger merged 5 commits intomodelcontextprotocol:mainfrom Jan 23, 2026
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
felixweinberger
approved these changes
Jan 23, 2026
Contributor
felixweinberger
left a comment
There was a problem hiding this comment.
Thanks for the fix! This aligns with how the Python SDK handles the same case (arguments or {}).
I made a couple small changes:
- Updated the test to use
registerToolinstead of the deprecatedtoolmethod - Moved the test to
test/issues/test400.optional-tool-params.test.tsto match our pattern for regression tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #400
Motivation and Context
When a tool has all optional parameters, some LLM models call the tool without providing an
argumentsfield. This causes Zod validation to fail with:MCP error -32602: Invalid arguments for tool [name]: Invalid input: expected object, received
undefined
Even though the schema allows all fields to be optional, Zod's
z.object()expects the inputitself to be an object, not
undefinedornull.How Has This Been Tested?
should accept undefined arguments when all tool params are optionalundefined→ fails with "expected object, received undefined"null→ fails with "expected object, received null"{}→ passes validationBreaking Changes
None. This is a backward-compatible fix that only affects edge cases where
argumentsisomitted.
Types of changes
Checklist
Additional context
The fix is a single line change in
packages/server/src/server/mcp.ts: