Restore AuthDebuggerState.resource as URL#714
Conversation
Not doing so prevents the resource URI from getting sent to the OAuth server's token endpoint during the "Quick OAuth flow"
🎭 Playwright E2E Test Results✅ 24 passed Details24 tests across 3 suites 📊 View Detailed HTML Report (download artifacts) |
|
@olaservo I approved the other PR, because my main motivation is to fix the inspector/client/src/lib/auth-types.ts Line 33 in 16edf53 Even if we decide to store the resource in a separate session state key, we should fix the AuthDebuggerState restore behavior so that it creates a valid object. And at that point, I don't know what the advantages of the 30 line change is over the 3 line change when you need to make the 3 line change anyway. Personally, I would probably just merge this PR over the other one for simplicities sake, but they're not mutually exclusive. |
|
Thanks for the explanation @halter73 , looks like there is just a formatting failure in the CI: https://github.com/modelcontextprotocol/inspector/actions/runs/16999856050/job/48199242030?pr=714 |
|
I ran |
Not doing so prevents the resource URI from getting sent to the OAuth server's token endpoint during the "Quick OAuth Flow"