-
Notifications
You must be signed in to change notification settings - Fork 384
Closed
Labels
help wantedContributions welcome from those familiar with codebase. Comment first to say you're working on itContributions welcome from those familiar with codebase. Comment first to say you're working on it
Description
Right now, the streamable client connection retries broken resumable connections up to StreamableClientTransport.MaxRetries, but once a connection has been re-established, the counter resets.
This can lead to a failure mode where a server keeps terminating the connection with status 200. We should either:
- Set a global limit on the number of retries across a single logical stream.
- Only reset the retry counter when the Last-Event-ID actually makes progress.
I'm leaning toward 2: if the stream is active and long-running, a global limit could be problematic. On the other hand, (2) doesn't have that problem, and still avoids the degenerate failure mode.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
help wantedContributions welcome from those familiar with codebase. Comment first to say you're working on itContributions welcome from those familiar with codebase. Comment first to say you're working on it