Fix a few issues with std verification#3255
Merged
celinval merged 4 commits intomodel-checking:mainfrom Jun 11, 2024
Merged
Conversation
- Contracts cannot duplicate some attributes. I think we need a better
solution than just duplicate all attributes, but for now just filter
the ones we know are problematic.
- Do not make contract generated functions `const` when annotating
constant functions.
- I also moved the compilation of no_core up since it is much faster.
- The `std` crate has type dylib and rlib.
jaisnan
reviewed
Jun 11, 2024
jaisnan
reviewed
Jun 11, 2024
340a337 to
9ae71b6
Compare
jaisnan
approved these changes
Jun 11, 2024
Contributor
jaisnan
left a comment
There was a problem hiding this comment.
I'm approving this. I assume there might some other attributes that might cause issues, but we can always add more to the filter or improve the filter in any case.
Contributor
Author
|
I think unstable might be one... not sure yet. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
constwhen annotating constant functions.Call-out
Need to add a test.
Resolves #3251
Resolves #3254
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.