Closed
Conversation
adpaco-aws
suggested changes
Jul 17, 2023
Contributor
adpaco-aws
left a comment
There was a problem hiding this comment.
Good work! A couple of high-level comments:
Why aren't filenames included in expected files? Looks like you're parsing file locations but only keep line numbers. Coverage data will give you information on external files (including Kani library or std functions), which we also need to store in order to make a correct comparison.
I'd also encourage you to use types to represent coverage data. That'd allow us to split this code into two parts: parsing and checking.
Comment on lines
+587
to
+590
| // Iterate through the blocks and find the ones containing "UNREACHABLE" or "SATISFIED" | ||
| for block in blocks { | ||
| if block.contains("UNREACHABLE") || block.contains("SATISFIED") { | ||
| blocks_with_unreachable_or_satisfied.push(block); |
Contributor
There was a problem hiding this comment.
Should be looking for UNSATISFIED and SATISFIED because those are the only two possible results for cover checks.
| } | ||
| } | ||
| } | ||
| if block.contains("UNREACHABLE") { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds coverage test suite
Resolved issues:
Resolves #ISSUE-NUMBER
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.