Polish cargo test arguments + add test#2492
Merged
celinval merged 2 commits intomodel-checking:mainfrom May 30, 2023
Merged
Conversation
jaisnan
approved these changes
May 30, 2023
Contributor
jaisnan
left a comment
There was a problem hiding this comment.
Thanks, the tests come in handy for the extension as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is a continuation from #2491. For completeness, I'm adding
--binoption. I've also added a test for these options. Finally, I moved cargo specific arguments to its own module.Resolved issues:
Resolves #ISSUE-NUMBER
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested? New test
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.