Explicitly pass out_file to benchcomp visualizers#2408
Merged
karkhaz merged 2 commits intomodel-checking:mainfrom Apr 27, 2023
Merged
Explicitly pass out_file to benchcomp visualizers#2408karkhaz merged 2 commits intomodel-checking:mainfrom
karkhaz merged 2 commits intomodel-checking:mainfrom
Conversation
8f70914 to
a477914
Compare
Member
I don't think this statement is true: https://github.com/actions/upload-artifact will happily upload artifacts even if an earlier step failed (there even is provision to only do so when an earlier step failed, see their docs). We make good use of this in https://github.com/diffblue/cbmc/blob/develop/.github/workflows/build-and-test-Linux.yaml, which will upload files to debug build failures. |
tautschnig
approved these changes
Apr 27, 2023
This commit adds an `out_file` to the benchcomp visualizes that emit output (currently just one visualization, dump_yaml). This is to allow different visualizations to be written to different output files, including stdout. The intention (for a future commit) is that CI will save certain visualizations as artifacts, which users can then download.
Contributor
Author
|
You're right, thank you. I've amended the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an
out_fileto the benchcomp visualizes that emit output (currently just one visualization, dump_yaml). This is to allow different visualizations to be written to different output files, including stdout.The intention (for a future commit) is that CI will save certain visualizations as artifacts, which users can then download.
Testing:
How is this change tested? Ran it locally
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.