Factor out niche value computation#2369
Closed
tautschnig wants to merge 1 commit intomodel-checking:mainfrom
Closed
Factor out niche value computation#2369tautschnig wants to merge 1 commit intomodel-checking:mainfrom
tautschnig wants to merge 1 commit intomodel-checking:mainfrom
Conversation
4 tasks
There will be future re-use of this code, so move it to a public function.
celinval
reviewed
Apr 13, 2023
Member
Author
|
Closing as, once squashed, #2347 will no longer need this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
There will be future re-use of this code, so move it to a public function.
Resolved issues:
n/a
Related RFC:
n/a
Call-outs:
n/a
Testing:
How is this change tested? Used in existing tests (in CI).
Is this a refactor change? Yes.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.