Merged
Conversation
4 tasks
13c579f to
00030c6
Compare
adpaco-aws
reviewed
Mar 8, 2023
Contributor
adpaco-aws
left a comment
There was a problem hiding this comment.
Thanks for writing this, @celinval !
Overall, I agree with the proposal. I've left some comments regarding motivation and other procedures (e.g., a warning) that I'd like you to consider.
adpaco-aws
reviewed
Mar 10, 2023
Contributor
adpaco-aws
left a comment
There was a problem hiding this comment.
It's looking great!
I'd only extend the "User Impact" section with an explanation on the current approach to unstable options, briefly mentioning its limitations.
zhassan-aws
approved these changes
Mar 10, 2023
Contributor
zhassan-aws
left a comment
There was a problem hiding this comment.
Looks good. Thanks @celinval!
fzaiser
reviewed
Mar 13, 2023
fzaiser
reviewed
Mar 13, 2023
fzaiser
reviewed
Mar 13, 2023
fzaiser
reviewed
Mar 13, 2023
Contributor
Contributor
|
Could I ask for an update given that #1659 is blocked on this? |
Contributor
Author
Conflicts: rfc/src/SUMMARY.md
adpaco-aws
approved these changes
Apr 5, 2023
Contributor
adpaco-aws
left a comment
There was a problem hiding this comment.
Thank you, @celinval !
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
4 tasks
4 tasks
This was referenced Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Create a RFC for feature gate for APIs included in the Kani library.
Resolved issues:
Related RFC:
Optional #2279
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.