Merged
Conversation
celinval
reviewed
Mar 7, 2023
Contributor
celinval
left a comment
There was a problem hiding this comment.
Are you able to also add a small test that reproduces this issue?
Contributor
Author
Do you mean the issue in #1949? If so, I did add a small test in my previous fix for it (see #2005), but turns out that the test doesn't fully reproduce the issue in the |
celinval
approved these changes
Mar 7, 2023
This was referenced Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The PR that fixed #2187 (#2194) broke #1949. Opening this PR to undo #2194 until we find a more reliable approach to fix #2187 (tracked by #2275).
Resolved issues:
Resolves #1949
Reopens #2187
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested? Added a new test
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.