Remove unused compiletest args from parsing & Config#1769
Merged
adpaco-aws merged 1 commit intomodel-checking:mainfrom Oct 11, 2022
Merged
Remove unused compiletest args from parsing & Config#1769adpaco-aws merged 1 commit intomodel-checking:mainfrom
adpaco-aws merged 1 commit intomodel-checking:mainfrom
Conversation
adpaco-aws
approved these changes
Oct 11, 2022
Contributor
adpaco-aws
left a comment
There was a problem hiding this comment.
Thanks @JanSvejda !
This is a breaking change for the compiletest CLI - is that ok?
Yes, the options removed here aren't used or wouldn't do anything even if they were.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Removes unused CLI arguments from parsing logic and Config class as per issue #754 , task 3.
Resolved issues:
Resolves #754
Call-outs:
This is a breaking change for the compiletest CLI - is that ok? I am unfamiliar with how compiletest is used here other than what I saw in the docs and scripts.
If the args used in the docs+scripts in this repo should be the only ones available, let me know. I will remove the rest.
Testing:
How is this change tested? With existing tests
Is this a refactor change? Yes
Checklist
(no new procs/methods added)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.