Audit for rintf* and nearbyintf* intrinsics#1277
Merged
adpaco-aws merged 6 commits intomodel-checking:mainfrom Jun 14, 2022
Merged
Audit for rintf* and nearbyintf* intrinsics#1277adpaco-aws merged 6 commits intomodel-checking:mainfrom
rintf* and nearbyintf* intrinsics#1277adpaco-aws merged 6 commits intomodel-checking:mainfrom
Conversation
tedinski
approved these changes
Jun 14, 2022
Contributor
Author
|
Updated all tests to require |
77 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Restores and completes the audit for the
rintf32(rintf),rintf64(rint),nearbyintf32(nearbyintf) andnearbyintf64(nearbyint) intrinsics.Resolved issues:
Part of #1163
Fixes #1025
Call-outs:
I've tried to add comments regarding things that may be confusing. Please let me know if something's not clear and I'll add more.
Testing:
How is this change tested? Adds 4 tests, removes 4 tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.