Skip to content

Add support for atomic_max* and atomic_umax* intinsics#1232

Merged
adpaco-aws merged 3 commits intomodel-checking:mainfrom
adpaco-aws:audit-atomic-max
May 27, 2022
Merged

Add support for atomic_max* and atomic_umax* intinsics#1232
adpaco-aws merged 3 commits intomodel-checking:mainfrom
adpaco-aws:audit-atomic-max

Conversation

@adpaco-aws
Copy link
Contributor

Description of changes:

Same deal as #1212, but this time for intrinsics using a max comparison.

Resolved issues:

Part of #1163

Call-outs:

#25 will be tackled in batch mode, after all atomic intrinsics are in.

Testing:

  • How is this change tested? Removes 10 negative tests, adds 2.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner May 27, 2022 15:20
Copy link
Contributor

@tedinski tedinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the test consolidation

@adpaco-aws adpaco-aws merged commit b0c4a4e into model-checking:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants