Skip to content

Remove ReadPtr hook#1189

Merged
danielsn merged 1 commit intomodel-checking:mainfrom
danielsn:read-ptr-hook
Jul 13, 2022
Merged

Remove ReadPtr hook#1189
danielsn merged 1 commit intomodel-checking:mainfrom
danielsn:read-ptr-hook

Conversation

@danielsn
Copy link
Contributor

@danielsn danielsn commented May 11, 2022

Description of changes:

The PtrRead hook is no longer necessary given that we support the underlying intrinsics.

Resolved issues:

Resolves #1175

Call-outs:

Thanks to optimizations in latest CBMC revision, performance seems comparable before and after this change.

Testing:

  • How is this change tested? Existing unit tests

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@danielsn danielsn requested a review from a team as a code owner May 11, 2022 16:23
@danielsn danielsn marked this pull request as draft May 11, 2022 16:23
@danielsn danielsn self-assigned this May 25, 2022
@danielsn
Copy link
Contributor Author

Blocked on diffblue/cbmc#6856

@danielsn danielsn force-pushed the read-ptr-hook branch 2 times, most recently from 486c9cf to d53ddbe Compare July 13, 2022 16:12
@danielsn danielsn marked this pull request as ready for review July 13, 2022 16:41
@danielsn danielsn merged commit 13f7a98 into model-checking:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Remove PtrRead hook

2 participants