Merged
Conversation
added 2 commits
February 27, 2023 10:53
255kb
requested changes
Feb 27, 2023
Member
255kb
left a comment
There was a problem hiding this comment.
Thanks for the contribution and for adding tests in the commons-server package.
There is a small issue that is breaking the desktop tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #962
Technical implementation details
When importing an OpenAPI specification file, the
examplesproperty of the specification is used to generate new route responses. Each example is transformed in a new route response and the default route response is the one generated from theschemaproperty.Checklist