Skip to content

Add support of WebDAV's HTTP Methods for Distributed Authoring#938

Merged
255kb merged 2 commits intomockoon:mainfrom
daniel-schulz:feature/937-support-webdav-http-methods
Feb 3, 2023
Merged

Add support of WebDAV's HTTP Methods for Distributed Authoring#938
255kb merged 2 commits intomockoon:mainfrom
daniel-schulz:feature/937-support-webdav-http-methods

Conversation

@daniel-schulz
Copy link
Contributor

@daniel-schulz daniel-schulz commented Feb 1, 2023

Added the following methods:

  • PROPFIND
  • PROPPATCH
  • MKCOL
  • COPY
  • MOVE
  • LOCK
  • UNLOCK

Closes #937

Technical implementation details

Checklist

  • data migration added (@mockoon/commons) => No migration relevant schema changes.
  • data migration automated tests added (@mockoon/commons) => No migration relevant schema changes.
  • CLI automated tests added (@mockoon/cli) => No changes to the CLI.
  • desktop automated tests added (@mockoon/desktop) => As discussed in this pr, no additional tests necessary.

@daniel-schulz daniel-schulz requested a review from 255kb as a code owner February 1, 2023 17:12
@daniel-schulz
Copy link
Contributor Author

daniel-schulz commented Feb 1, 2023

Do we need automated tests for this trivial change?
I didn't find any existing desktop tests for specific HTTP methods. Just some basic ones like should be able to select a method by clicking and should be able to select a method by navigating with keyboard.

@daniel-schulz daniel-schulz force-pushed the feature/937-support-webdav-http-methods branch from c851a50 to e14375c Compare February 1, 2023 18:17
@255kb
Copy link
Member

255kb commented Feb 2, 2023

Do we need automated tests for this trivial change? I didn't find any existing desktop tests for specific HTTP methods. Just some basic ones like should be able to select a method by clicking and should be able to select a method by navigating with keyboard.

I think it's ok. There is not much to test as these words are passed "as-is" to Node.js

Thank you for the contribution and for updating the contributing guidelines.

Can you fix the linting/formatting? I will then merge and it will be included in the next release.

Copy link
Member

@255kb 255kb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting

@daniel-schulz daniel-schulz force-pushed the feature/937-support-webdav-http-methods branch 3 times, most recently from 4cae0db to 870829c Compare February 2, 2023 16:02
@daniel-schulz
Copy link
Contributor Author

daniel-schulz commented Feb 2, 2023

Strange, the command npm run lint didn't gave any hints about the issues:
image

Also the command npm run format didn't seem to work properly on my machine:
image

But I manually executed prettier on the changed files and hope the CI linter will accept it now.

Can you re-trigger the CI pipeline?

@daniel-schulz daniel-schulz force-pushed the feature/937-support-webdav-http-methods branch from 870829c to edf5b63 Compare February 2, 2023 16:34
Added the following methods:
* PROPFIND
* PROPPATCH
* MKCOL
* COPY
* MOVE
* LOCK
* UNLOCK

Closes mockoon#937
@daniel-schulz daniel-schulz force-pushed the feature/937-support-webdav-http-methods branch from edf5b63 to dc62770 Compare February 2, 2023 16:52
@daniel-schulz
Copy link
Contributor Author

I've triggered the ci pipeline in my fork and fixed all the upcoming issues.
=> This PR should be merge ready - finally! :-)

@255kb
Copy link
Member

255kb commented Feb 3, 2023

Strange, the command npm run lint didn't gave any hints about the issues: image

Also the command npm run format didn't seem to work properly on my machine: image

But I manually executed prettier on the changed files and hope the CI linter will accept it now.

Can you re-trigger the CI pipeline?

Yeah sorry the formatting was failing not the linting. But the error you get is really strange, the command usually works (I use it in multiple env, Windows, Linux , etc.). I have no idea what happened.

Thanks for fixing everything 🙂

@255kb 255kb merged commit 1e1936f into mockoon:main Feb 3, 2023
@daniel-schulz daniel-schulz deleted the feature/937-support-webdav-http-methods branch February 3, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support WebDAV's HTTP Methods for Distributed Authoring

2 participants