Skip to content

Fix settings save race condition#752

Merged
255kb merged 1 commit intomainfrom
fix/751-settings-race-condition
Jul 12, 2022
Merged

Fix settings save race condition#752
255kb merged 1 commit intomainfrom
fix/751-settings-race-condition

Conversation

@255kb
Copy link
Member

@255kb 255kb commented Jul 12, 2022

Save method was sometimes saving the initial state of the store's settings.

Closes #751

Technical implementation details

Checklist

  • data migration added (@mockoon/commons)
  • data migration automated tests added (@mockoon/commons)
  • CLI automated tests added (@mockoon/cli)
  • desktop automated tests added (@mockoon/desktop)

Save method was sometimes saving the initial state of the store's settings. 

Closes #751
@255kb 255kb merged commit 9f3915f into main Jul 12, 2022
@255kb 255kb deleted the fix/751-settings-race-condition branch July 12, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race condition when saving the desktop app settings

1 participant