Skip to content

Re-enable and improve file watching#696

Merged
255kb merged 1 commit intomainfrom
fix/649-file-watching
May 2, 2022
Merged

Re-enable and improve file watching#696
255kb merged 1 commit intomainfrom
fix/649-file-watching

Conversation

@255kb
Copy link
Member

@255kb 255kb commented May 2, 2022

  • working on a race condition between rewatch delay and subsequent save
  • make file watcher cancel triggered rewatch
  • Change confirm modal behavior: returns a boolean for confirm or cancel, can display a list of strings, can customize buttons
  • add two options for file watch: disabled, prompt or auto
  • manage file monitoring in the main thread instead of the renderer
  • Revert to a real environment reload through the store instead of a close/re-open
  • create a new "reload" view if environment is focused (this shouldn't be seen often)
  • run packaged tests on PRs too

Closes #649

Parent issue

Closes #insert_issue_number_here

Technical implementation details

Checklist

  • data migration added (@mockoon/commons)
  • data migration automated tests added (@mockoon/commons)
  • CLI automated tests added (@mockoon/cli)
  • desktop automated tests added (@mockoon/desktop)

@255kb 255kb force-pushed the fix/649-file-watching branch 3 times, most recently from 40039cc to 6d746bf Compare May 2, 2022 09:15
- working on a race condition between rewatch delay and subsequent save
- make file watcher cancel triggered rewatch
- Change confirm modal behavior: returns a boolean for confirm or cancel, can display a list of strings, can customize buttons
- add two options for file watch: disabled, prompt or auto
- manage file monitoring in the main thread instead of the renderer
- Revert to a real environment reload through the store instead of a close/re-open
- create a new "reload" view if environment is focused (this shouldn't be seen often)
- run packaged tests on PRs too

Closes #649
@255kb 255kb merged commit c8653a0 into main May 2, 2022
@255kb 255kb deleted the fix/649-file-watching branch May 2, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic env reload reloads forever and shuffles the sidebar

1 participant